feat(langsmith): add config.settings.webhookRequestTimeoutSec - #945
Open
Matthew Chan (mcschan) wants to merge 1 commit into
Open
feat(langsmith): add config.settings.webhookRequestTimeoutSec#945Matthew Chan (mcschan) wants to merge 1 commit into
Matthew Chan (mcschan) wants to merge 1 commit into
Conversation
Automation rule and prompt webhooks previously had a hardcoded 5 second timeout. The backend now reads WEBHOOK_REQUEST_TIMEOUT_SEC, defaulting to 10 seconds on LangSmith Cloud and 5 on self-hosted. Expose it as a chart value defaulted to 5 so upgrading does not change how long a rules worker slot is held. Operators whose webhook endpoint needs longer can raise it without editing commonEnv. The value is templated into langsmith.commonEnv, which the queue deployment includes -- automation rules fire from the rules worker, not the API backend, so backend.deployment.extraEnv alone would not reach them. Ref: LSO-810
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
config.settings.webhookRequestTimeoutSec, defaulted to"5", and templates it intolangsmith.commonEnvasWEBHOOK_REQUEST_TIMEOUT_SEC.Why
Automation rule and prompt webhooks had a hardcoded 5 second timeout in the backend. LSO-810 asks for 10s — customer endpoints often need longer than 5s, and today they work around it by returning
200immediately and processing asynchronously.The companion
langchainpluschange makes the timeout configurable viaWEBHOOK_REQUEST_TIMEOUT_SECand defaults it to 10s on LangSmith Cloud, 5s on self-hosted. Self-hosted stays at 5s deliberately: a longer timeout holds a rules worker slot longer, and we can neither observe nor quickly roll back those deployments.This PR gives operators a first-class knob so raising it doesn't require hand-editing
commonEnv.Notes
langsmith.commonEnvrather than a per-serviceextraEnvbecause automation rules fire from the queue worker, not the API backend —backend.deployment.extraEnvalone would silently have no effect.SharedSettingsis configuredextra="ignore", so an older image treats the variable as a no-op.0.17.0-rc.6→0.17.0-rc.7forct lint's version-increment check.README.mdrows added by hand in helm-docs format (helm-docs isn't installed locally); worth a skim.Test plan
ct lintandhelm unittestpasshelm templateshowsWEBHOOK_REQUEST_TIMEOUT_SEC: "5"on the queue and backend deploymentsconfig.settings.webhookRequestTimeoutSec: "10"renders"10"